Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Explicitly set section IDs for Asciidoctor migration #41550

Merged
merged 1 commit into from
Apr 25, 2019
Merged

[DOCS] Explicitly set section IDs for Asciidoctor migration #41550

merged 1 commit into from
Apr 25, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 25, 2019

The following page URLs contain autogenerated IDs:

With the Asciidoctor migration, these IDs would change and result in broken links.

This explicitly sets the IDs so the page URLs are stable during Asciidoctor migration.

I plan to backport this to 2.2. Relates to #41128 and elastic/docs#827.

@jrodewig jrodewig requested a review from nik9000 April 25, 2019 19:04
@jrodewig jrodewig added :Docs >docs General docs changes labels Apr 25, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jrodewig jrodewig merged commit 3f9efc1 into elastic:2.4 Apr 25, 2019
@jrodewig jrodewig deleted the asciidoctor-fix-profile-section-ids branch April 25, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants