Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Specify ID for index property to prepare for Asciidoctor migration #41507

Merged
merged 1 commit into from
Apr 24, 2019
Merged

[DOCS] Specify ID for index property to prepare for Asciidoctor migration #41507

merged 1 commit into from
Apr 24, 2019

Conversation

jrodewig
Copy link
Contributor

In the 5.x version of the Elasticsearch.Net docs, the NEST Breaking Changes page links to an auto-generated anchor in the 5.0 Elasticsearch reference.

This is bad practice generally, but the link breaks in Asciidoctor. This PR adds the anchor to Elasticsearch reference so the Elasticsearch.Net link does not break during Asciidoctor migration.

Relates to #41128 and elastic/docs#827.

@jrodewig jrodewig added >docs General docs changes :Docs labels Apr 24, 2019
@jrodewig jrodewig requested a review from nik9000 April 24, 2019 19:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@nik9000
Copy link
Member

nik9000 commented Apr 24, 2019

The builds fail here because this is targeting the 5.0 branch.

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 718db67 into elastic:5.0 Apr 24, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors-index-property branch April 24, 2019 21:37
@jrodewig jrodewig restored the fix-asciidoctor-errors-index-property branch April 24, 2019 22:46
@jrodewig jrodewig deleted the fix-asciidoctor-errors-index-property branch May 6, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants