Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ccr follow info api to HLRC. #39115

Merged
merged 3 commits into from
Feb 20, 2019

Conversation

martijnvg
Copy link
Member

This API was recently introduced via #37408, but the hlrc side is still missing.
Relates to #33824

This API was introduces after elastic#33824 was closed.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super easy to read. Youve done this before, i can tell ;)

Also, I just noticed (after all these reviews heh) that there is no CCRRequestConvertersTests class... Could you add that in a new PR or put up a GH ticket so someone can do it?

PARSER.declareObjectArray(ConstructingObjectParser.constructorArg(), FollowerInfo.PARSER, FOLLOWER_INDICES_FIELD);
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline

Collections.emptySet()
);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

@martijnvg
Copy link
Member Author

Could you add that in a new PR or put up a GH ticket so someone can do it?

👍I will open a follow up pr for this.

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/bwc

@martijnvg martijnvg merged commit 1516132 into elastic:master Feb 20, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 20, 2019
* master:
  Mute failing CCR retention lease unfollow test
  Add support for ccr follow info api to HLRC. (elastic#39115)
  Do not create the missing index when invoking getRole (elastic#39039)
  Relax history check in ShardFollowTaskReplicationTests (elastic#39162)
  Add retention leases replication tests (elastic#38857)
  Edits to text in Phrase Suggester doc (elastic#38966)
  Edits to text in API Conventions docs (elastic#39001)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 20, 2019
* master:
  Mute failing CCR retention lease unfollow test
  Add support for ccr follow info api to HLRC. (elastic#39115)
  Do not create the missing index when invoking getRole (elastic#39039)
  Relax history check in ShardFollowTaskReplicationTests (elastic#39162)
  Add retention leases replication tests (elastic#38857)
  Edits to text in Phrase Suggester doc (elastic#38966)
  Edits to text in API Conventions docs (elastic#39001)
martijnvg added a commit that referenced this pull request Feb 20, 2019
This API was introduces after #33824 was closed.
martijnvg added a commit that referenced this pull request Feb 20, 2019
This API was introduces after #33824 was closed.
martijnvg added a commit that referenced this pull request Feb 20, 2019
This API was introduces after #33824 was closed.
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants