Specify include_type_name in HTTP monitoring. #38927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features |
In 6.7, `include_type_name` must be specified in order to avoid deprecation warnings. Here we make sure to use `include_type_name` when setting up templates for the monitoring HTTP exporter.
jtibshirani
force-pushed
the
monitoring-types-warnings
branch
from
c5f652f
to
bb4cfcf
Compare
jtibshirani
force-pushed
the
monitoring-types-warnings
branch
from
4d9e4fa
to
25eb787
Compare
jakelandis
reviewed
Feb 14, 2019
| Map<String, String> parameters = new HashMap<>( | ||
| PublishableHttpResource.RESOURCE_VERSION_PARAMETERS); | ||
| parameters.put(INCLUDE_TYPE_NAME_PARAMETER, "true"); | ||
| PARAMETERS = Collections.unmodifiableMap(parameters); |
There was a problem hiding this comment.
nit: I think you can use https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/common/collect/MapBuilder.java#L87 to shorten this up abit.
There was a problem hiding this comment.
Nice, I didn't realize we had that.
|
@jakelandis @ycombinator thank you for the reviews! After this merges, it would be good to test HTTP monitoring on 6.7 to make sure there are no deprecation warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6.7,
include_type_namemust be specified in order to avoid deprecationwarnings. Here we make sure to use
include_type_namewhen setting up templatesfor the monitoring HTTP exporter.
Addresses #37442.