Fix NPE on Stale Index in IndicesService #38891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We should treat a `null` return for the metadata as equal to an error and break out * Added the check at this level even though it required nested `throw`, because adding it further downstream would impact other functionality * Closes elastic#38845
original-brownbear
added
>bug
:Distributed/Distributed
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Feb 14, 2019
server/src/main/java/org/elasticsearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
|
I see the original issue failing in 7.0, so I added that version label to this PR |
ywelsch
approved these changes
Feb 15, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 15, 2019
* elastic/master: Avoid double term construction in DfsPhase (elastic#38716) Fix typo in DateRange docs (yyy → yyyy) (elastic#38883) Introduced class reuses follow parameter code between ShardFollowTasks (elastic#38910) Ensure random timestamps are within search boundary (elastic#38753) [CI] Muting method testFollowIndex in IndexFollowingIT Update Lucene snapshot repo for 7.0.0-beta1 (elastic#38946) SQL: Doc on syntax (identifiers in particular) (elastic#38662) Upgrade to Gradle 5.2.1 (elastic#38880) Tie break search shard iterator comparisons on cluster alias (elastic#38853) Also mmap cfs files for hybridfs (elastic#38940) Build: Fix issue with test status logging (elastic#38799) Adapt FullClusterRestartIT on master (elastic#38856) Fix testAutoFollowing test to use createLeaderIndex() helper method. Migrate muted auto follow rolling upgrade test and unmute this test (elastic#38900) ShardBulkAction ignore primary response on primary (elastic#38901) Recover peers from translog, ignoring soft deletes (elastic#38904) Fix NPE on Stale Index in IndicesService (elastic#38891) Smarter CCR concurrent file chunk fetching (elastic#38841) Fix intermittent failure in ApiKeyIntegTests (elastic#38627) re-enable SmokeTestWatcherWithSecurityIT (elastic#38814)
jkakavas
pushed a commit
to jkakavas/elasticsearch
that referenced
this pull request
Feb 20, 2019
jkakavas
pushed a commit
to jkakavas/elasticsearch
that referenced
this pull request
Feb 20, 2019
jkakavas
added a commit
that referenced
this pull request
Feb 20, 2019
jkakavas
added a commit
that referenced
this pull request
Feb 20, 2019
|
@original-brownbear after seeing more reports of this, I think we should backport this one to 6.7 |
|
@ywelsch sounds good, will back port shortly :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 9, 2019
original-brownbear
added a commit
that referenced
this pull request
Apr 9, 2019
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jul 31, 2019
The issue mentioned (elastic#38845) seems to have been closed with elastic#38891 so the test can be re-activated.
cbuescher
pushed a commit
that referenced
this pull request
Jul 31, 2019
cbuescher
pushed a commit
that referenced
this pull request
Jul 31, 2019
cbuescher
pushed a commit
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullreturn for the metadata as equal to an error and break outthrowbecause adding it further downstream would impact other functionality