Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _type term filters from cluster alert watches (#38819) #38827

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

ycombinator
Copy link
Contributor

Backport of #38819. Original message:

This PR removes usages of the _type field in _search requests issued from Monitoring code.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@ycombinator
Copy link
Contributor Author

@jpountz @bleskes This PR is a backport to the 7.0 branch so @jakelandis suggested to get your approval before merging it, since it's past 7.0 FF.

@jakelandis
Copy link
Contributor

@jpountz @bleskes This PR is a backport to the 7.0 branch so @jakelandis suggested to get your approval before merging it, since it's past 7.0 FF.

Just wanted raise awareness that we are proceeding with the removal of types for monitoring, targeting (at least) 7.0 GA. (likely rc1) This happens to be the first of a few related PR's, please thumbs up to approve this initiative back 7.0 (no need to review code, we are doing that on the original PRs).

@ycombinator ycombinator merged commit 154e97e into elastic:7.0 Feb 13, 2019
@ycombinator ycombinator deleted the backport-38819-70 branch February 13, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants