Freezing an index should increase its index settings version #37813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>non-issue
v7.0.0
:Distributed/Distributed
|
Pinging @elastic/es-distributed |
|
@elasticmachine run elasticsearch-ci/2 |
|
Thanks @dnhatn ! |
tlrx
added a commit
that referenced
this pull request
Jan 25, 2019
When an index is frozen, two index settings are updated (index.frozen and index.search.throttled) but the settings version is left unchanged and does not reflect the settings update. This commit change the TransportFreezeIndexAction so that it also increases the settings version when an index is frozen/unfrozen. This issue has been caught while working on the replication of closed indices (#3388) in which index metadata for a closed index are updated to frozen metadata and this specific assertion tripped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an index is frozen, two index settings are updated (
index.frozenandindex.search.throttled) but the settings version is left unchanged and does not reflect the settings update. This pull request change the TransportFreezeIndexAction so that it also increases the settings version when an index is frozen/unfrozen.This issue has been caught while working on the replication of closed indices (#3388) in which index metadata for a closed index are updated to frozen metadata and this specific assertion tripped.