Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default for include_type_name to false. #37285

Merged
merged 21 commits into from
Jan 14, 2019
Merged

Update the default for include_type_name to false. #37285

merged 21 commits into from
Jan 14, 2019

Commits on Jan 13, 2019

  1. Add a constant for the default include_type_name value.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    376dc7d View commit details
    Browse the repository at this point in the history

  2. Some minor clean-ups around the get index API.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    ddf73b9 View commit details
    Browse the repository at this point in the history

  3. Default include_type_name to false for get and put mappings.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    83b4be1 View commit details
    Browse the repository at this point in the history

  4. Default include_type_name to false for get field mappings.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    b96d640 View commit details
    Browse the repository at this point in the history

  5. Default include_type_name to false for get and put index templates.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    776b097 View commit details
    Browse the repository at this point in the history

  6. Default include_type_name to false for create index.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    2495ae7 View commit details
    Browse the repository at this point in the history

  7. Update create index calls in REST documentation to use include_type_n… 

    …ame=true.
    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    8b74660 View commit details
    Browse the repository at this point in the history

  8. In REST tests, use include_type_name=true by default for index creation.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    0edfc3b View commit details
    Browse the repository at this point in the history

  9. Make sure to use 'expression == false'.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    1f202c8 View commit details
    Browse the repository at this point in the history

  10. Clarify the different IndexTemplateMetaData toXContent methods.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    af45f15 View commit details
    Browse the repository at this point in the history

  11. Fix FullClusterRestartIT#testSnapshotRestore.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    92f8243 View commit details
    Browse the repository at this point in the history

  12. Fix the ml_anomalies_default_mappings test.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    197746e View commit details
    Browse the repository at this point in the history

  13. Fix GetFieldMappingsResponseTests and GetIndexTemplateResponseTests. 

    We make sure to specify include_type_name=true during xContent parsing,
so we continue to test the legacy typed responses. XContent generation
for the typeless responses is currently only covered by REST tests,
but we will be adding unit test coverage for these as we implement
each typeless API in the Java HLRC.

This commit also refactors GetMappingsResponse to follow the same appraoch
as the other mappings-related responses, where we read include_type_name
out of the xContent params, instead of creating a second toXContent method.
This gives better consistency in the response parsing code.
    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    ace36e0 View commit details
    Browse the repository at this point in the history

  14. Improve some wording in the create index documentation.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    0b33b85 View commit details
    Browse the repository at this point in the history

  15. Add a note about types removal in the create index docs.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    a6e0ada View commit details
    Browse the repository at this point in the history

  16. Fix more REST tests.

    @jtibshirani
    jtibshirani committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    8c32905 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Fix SmokeTestMonitoringWithSecurityIT#testHTTPExporterWithSSL.

    @jtibshirani
    jtibshirani committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    7497ce8 View commit details
    Browse the repository at this point in the history

  2. Make sure to mention include_type_name in the REST docs for affected … 

    …APIs.
    @jtibshirani
    jtibshirani committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    0ee6bc7 View commit details
    Browse the repository at this point in the history

  3. Make sure to use 'expression == false' in FullClusterRestartIT.

    @jtibshirani
    jtibshirani committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    35b7b47 View commit details
    Browse the repository at this point in the history

  4. Mention include_type_name in the REST templates docs.

    @jtibshirani
    jtibshirani committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    03115c3 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into include-type-name… 

    …-default
    @jtibshirani
    jtibshirani committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    e3281dc View commit details
    Browse the repository at this point in the history