Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'node_selector' for type-less yaml-tests in mixed clusters #36717

Closed
wants to merge 2 commits into from
Closed

Use 'node_selector' for type-less yaml-tests in mixed clusters #36717

wants to merge 2 commits into from

Commits on Dec 17, 2018

  1. Use 'node_selector' for type-less yaml-tests in mixed clusters 

    Currently we skip yaml integration tests using the new typless API versions for
all clusters where any node has a version earlier than 7.0. This effectively
means we don't run this tests in mixed clusters or uphrade scenarios, which is
why we also copy each test to a version "*_with_type".

The integration test framework seems to have a feature where do-sections can
specify that a node it is run agains has a certain version or provides certain
features. We can use this "node_selector" feature to make sure we only hit nodes
in version >7.0 in the yaml tests that use type-less API calls. This way we
don't have to effectively disable mixed version or bwc tests and we might reduce
the number of tests we need to copy using the old typed APIs to the bare minimum
since we already cover most of the other testing with the new typless versions.

This PR shows this with the "_explain" API as an example.
    Christoph Büscher committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    ce2298c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into use-node_selector-yaml

    Christoph Büscher committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    73a0625 View commit details
    Browse the repository at this point in the history