[Close Index API] Propagate tasks ids between Freeze, Close and Verify Shard actions #36630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
v7.0.0
:Distributed/Distributed
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Dec 14, 2018
...n/java/org/elasticsearch/action/admin/indices/close/CloseIndexClusterStateUpdateRequest.java
Outdated
Show resolved
Hide resolved
...n/java/org/elasticsearch/action/admin/indices/close/CloseIndexClusterStateUpdateRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataIndexStateService.java
Outdated
Show resolved
Hide resolved
tlrx
force-pushed
the
close-index-api-refactoring
branch
2 times, most recently
from
51005de
to
ef6ae69
Compare
|
@elasticmachine run the default distro tests |
|
@elasticmachine test this please |
1 similar comment
|
@elasticmachine test this please |
|
@elasticmachine run gradle build tests 1 |
|
Thanks @ywelsch |
tlrx
added a commit
that referenced
this pull request
Jan 14, 2019
This commit backports to 6.x of the Close Index API refactoring. It cherry-picks the following commits from master: 3ca885e [Close Index API] Add TransportShardCloseAction for pre-closing verifications (#36249) 8e5dd20 [Close Index API] Refactor MetaDataIndexStateService (#36354) 7372529 [Tests] Reduce randomization in CloseWhileRelocatingShardsIT (#36694) 103c4d4 [Close Index API] Mark unavailable shard copy as stale during verification (#36755) 1959388 [Close Index API] Propagate tasks ids between Freeze, Close and Verify(#36630) e149b08 [Close Index API] Add unique UUID to ClusterBlock (#36775) dc371ef [Tests] Fix ReopenWhileClosingIT with correct min num shards The following two commits were needed to adapt the change to 6.x: ef6ae69 [Close Index API] Adapt MetaDataIndexStateServiceTests after merge 21b7653 [Tests] Adapt CloseIndexIT tests for 6.x Related to #33888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this pull request will be merged in the
close-index-api-refactoringbranchThis pull request changes the Freeze Index and Close Index actions so that these actions always requires a
Task. The task's id is then propagated from the Freeze action to the Close action, and then to the Verify shard action. This way it is possible to track which Freeze task initiates the closing of an index, and which consecutive verifiy shard are executed for the index closing.This change has no tests - I could write one using a MockTaskManager listener but it seemed a bit overkill to me.