[ML] JIndex: Job exists and get job should read cluster state first. #36305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
| @@ -366,6 +341,13 @@ public void putJob(PutJobAction.Request request, AnalysisRegistry analysisRegist | |||
| return; | |||
| } | |||
|
|
|||
| // Check the job id is not the same as a group Id | |||
| if (currentMlMetadata.isGroupOrJob(job.getId())) { | |||
There was a problem hiding this comment.
Are we also validating this when the job is written to the index?
There was a problem hiding this comment.
There are 2 checks here
- that the job id is not a group
- that any groups the job has are not job Ids
I realised the second was missing so I pushed another commit with that. Previously those checks were done in the constructor of MlMetadata which further made me realise I need to perform the same check on job update so I made that change also.
davidkyle
force-pushed
the
get-job-prefer-clusterstate
branch
from
d6f7b9b
to
f63f964
Compare
|
retest this please |
Also check the job Id is not a clusterstate group ID
davidkyle
force-pushed
the
get-job-prefer-clusterstate
branch
from
f63f964
to
263ab23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch PR
Changing methods missed in #36014 - get job and job exists.
This also adds in a missing check on PUT job that the job Id is not the same as a group Id defined in clusterstate jobs and a another check on job update that the jobs groups are not job ids.