Forbid empty testing tasks #36259
Merged
Forbid empty testing tasks #36259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#34820 With this change we allow for no tests being ran in randomized testing task, and forbid empty testing tasks from the testing conventions task. We will no longer have to disable the task if all tests are muted.
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
nik9000
approved these changes
Dec 5, 2018
| @@ -773,7 +773,6 @@ class BuildPlugin implements Plugin<Project> { | |||
| project.tasks.withType(RandomizedTestingTask) {task -> | |||
| jvm "${project.runtimeJavaHome}/bin/java" | |||
| parallelism System.getProperty('tests.jvms', project.rootProject.ext.defaultParallel) | |||
| ifNoTests System.getProperty('tests.ifNoTests', 'fail') | |||
There was a problem hiding this comment.
I spent a few minutes wondering if we should change this to ignore but I figured that removing it like this seemed right. I couldn't think of a good reason why someone might want to change this on the command line rather than rely on TestingConventionsTask.
alpar-t
added a commit
that referenced
this pull request
Dec 10, 2018
Closes #34820 With this change we allow for no tests being ran in randomized testing task, and forbid empty testing tasks from the testing conventions task. We will no longer have to disable the task if all tests are muted.
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Jan 23, 2019
Reverts elastic#36259 in part to make randomized test fail if no tests are ran. This is useful when filtering tests as it's easy to make a typo and think the test ran trough successfully.
alpar-t
added a commit
that referenced
this pull request
Jan 24, 2019
Reverts #36259 in part to make randomized test fail if no tests are ran. This is useful when filtering tests as it's easy to make a typo and think the test ran trough successfully.
alpar-t
added a commit
that referenced
this pull request
Jan 24, 2019
Reverts #36259 in part to make randomized test fail if no tests are ran. This is useful when filtering tests as it's easy to make a typo and think the test ran trough successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34820
With this change we allow for no tests being ran in randomized testing
task, and forbid empty testing tasks from the testing conventions task.
We will no longer have to disable the task if all tests are muted.