Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation check for tribe node #36240

Merged
merged 7 commits into from
Dec 10, 2018
Merged

Deprecation check for tribe node #36240

merged 7 commits into from
Dec 10, 2018

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Dec 4, 2018

Adds a deprecation check for tribe node.

Relates to #36024 and #28443

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

return new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Tribe Node removed in favor of Cross Cluster Search",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking_70_cluster_changes.html" +
"#_tribe_node_removed",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should work once #36239 is merged.

@gwbrown
Copy link
Contributor Author

gwbrown commented Dec 6, 2018

These test failures appear to be due to the BWC problems around 5.6.15.

@elasticmachine test this please

Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown
Copy link
Contributor Author

gwbrown commented Dec 7, 2018

Failure does not reproduce locally and appears unrelated.
@elasticmachine run gradle build tests 1

@gwbrown gwbrown merged commit 50a3dfa into elastic:6.x Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants