[ML] Job in index: Enable get and update actions for clusterstate jobs #35598
Conversation
|
Pinging @elastic/ml-core |
|
|
||
| if (config != null) { | ||
| listener.onResponse(config); | ||
| } else { |
There was a problem hiding this comment.
Why isn't this the other way around? I would think that since we are moving towards putting things in the index, that we would want that to be our positive path, and we would always check it first and return it if we find it.
This concern is also for https://github.com/elastic/elasticsearch/pull/35598/files#diff-db8b21d42edc9e4fada4630d49530113R141
There was a problem hiding this comment.
True I haven't been entirely consistent with this. The check for the config in cluster state doesn't require an async call so it makes sense to do the fast check first, then the order of the branching is based on what thoughts I could manage to keep in my brain. Note these code paths are only in 6.6 and 6.7 and will be maintained until 6.7.final_ever_bug_release
There was a problem hiding this comment.
Ah, I did not know these predicates were only for specific versions.
davidkyle
force-pushed
the
get-actions
branch
from
839a2ab
to
ef1e081
Compare
|
The tests were failing because there was no index mapping for |
|
run gradle build tests |
davidkyle
force-pushed
the
get-actions
branch
from
460b280
to
98625b5
Compare
|
run gradle build tests |
In 6.6 and 6.7 job and datafeed configuration may be clusterstate or the index. As with #35590 these changes are mostly testing for the location of the config and reinstating the old clusterstate config update code.
This PR covers the get and update actions and is the last change for required for running mixed config jobs.