Remove AbstractComponent from AbstractLifecycleComponent #35560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractLifecycleComponent now no longer extends AbstractComponent. In order to accomplish this, many, many classes now instantiate their own logger.
gwbrown
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
…tractlifecyclecomponent
…tractlifecyclecomponent
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Nov 19, 2018
AbstractLifecycleComponent now no longer extends AbstractComponent. In order to accomplish this, many, many classes now instantiate their own logger.
gwbrown
added a commit
that referenced
this pull request
Nov 19, 2018
AbstractLifecycleComponent now no longer extends AbstractComponent. In order to accomplish this, many, many classes now instantiate their own logger.
|
Removed the last usages from AbstractComponent here: #35898 |
gwbrown
deleted the
refactor/remove-abstractcomponent-from-abstractlifecyclecomponent
branch
pgomulka
added a commit
that referenced
this pull request
Jan 16, 2019
The AbstracLifecycleComponent used to extend AbstractComponent, so it had to pass settings to the constractor of its supper class. It no longer extends the AbstractComponent so there is no need for this constructor There is also no need for AbstracLifecycleComponent subclasses to have Settings in their constructors if they were only passing it over to super constructor. This is part 1. which will be backported to 6.x with a migration guide/deprecation log. part 2 will have this constructor removed in 7 relates #35560 relates #34488
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 16, 2019
…elastic#37488) The AbstracLifecycleComponent used to extend AbstractComponent, so it had to pass settings to the constractor of its supper class. It no longer extends the AbstractComponent so there is no need for this constructor There is also no need for AbstracLifecycleComponent subclasses to have Settings in their constructors if they were only passing it over to super constructor. This is part 1. which will be backported to 6.x with a migration guide/deprecation log. part 2 will have this constructor removed in 7 relates elastic#35560 relates elastic#34488
This was referenced Jan 16, 2019
pgomulka
added a commit
that referenced
this pull request
Jan 17, 2019
pgomulka
added a commit
that referenced
this pull request
Jan 17, 2019
…88 (#37522) The AbstractLifecycleComponent used to extend AbstractComponent, so it had to pass settings to the constructor of its supper class. It no longer extends the AbstractComponent so there is no need for this constructor There is also no need for AbstractLifecycleComponent subclasses to have Settings in their constructors if they were only passing it over to super constructor. This is part 1. which will be backported to 6.x with a migration guide/deprecation log. part 2 will have this constructor removed in 7 relates #35560 relates #34488
mpereira
added a commit
to mesosphere/elasticsearch-statsd-plugin
that referenced
this pull request
Mar 11, 2019
`AbstractLifecycleComponent` doesn't extend `AbstractComponent` anymore, so the logging facilities are unavailable. The changes in the Elasticsearch codebase now make classes instantiate their own logger objects. See more details in elastic/elasticsearch#35560.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractLifecycleComponent now no longer extends AbstractComponent. In
order to accomplish this, many, many classes now instantiate their own
logger.
Relates to #34488