Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow negative query boost #34486

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Oct 15, 2018

This change disallows negative query boosts. Negative scores are not allowed in Lucene 8 so
it is easier to just disallow negative boosts entirely. We should also deprecate negative boosts
in 6x in order to ensure that users are aware when they'll upgrade to ES 7.

Relates #33309

This change disallows negative query boosts. Negative scores are not allowed in Lucene 8 so
it is easier to just disallow negative boosts entirely. We should also deprecate negative boosts
in 6x in order to ensure that users are aware when they'll upgrade to ES 7.

Relates elastic#33309
@jimczi jimczi added >breaking :Search/Search Search-related issues that do not fall into other categories v7.0.0 labels Oct 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jimczi jimczi mentioned this pull request Oct 15, 2018
5 tasks
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimczi jimczi merged commit 544de13 into elastic:master Oct 16, 2018
@jimczi jimczi deleted the disallow_negative_boosts branch October 16, 2018 10:31
jimczi added a commit to jimczi/elasticsearch that referenced this pull request Oct 16, 2018
This change deprecates negative query boosts. Negative scores are not allowed in Lucene 8 so
it is easier to just disallow negative boosts entirely.

Relates elastic#33309
jimczi added a commit that referenced this pull request Oct 16, 2018
This change deprecates negative query boosts. Negative scores are not allowed in Lucene 8 so
it is easier to just disallow negative boosts entirely.

Relates #33309
kcm pushed a commit that referenced this pull request Oct 30, 2018
This change disallows negative query boosts. Negative scores are not allowed in Lucene 8 so
it is easier to just disallow negative boosts entirely. We should also deprecate negative boosts
in 6x in order to ensure that users are aware when they'll upgrade to ES 7.

Relates #33309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants