Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to multiple fields with one name #31127

Conversation

DaveCTurner
Copy link
Contributor

If there is only one type per index then each field's name is unique.

Not sure whether this should be backported to 6.x - it still applies there in the sense that indices created in 5.x might still be present. Guidance appreciated.

If there is only one type per index then each field's name is unique.
@DaveCTurner DaveCTurner added >docs General docs changes :Analytics/Aggregations Aggregations v7.0.0 labels Jun 6, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@DaveCTurner DaveCTurner merged commit 6ad7217 into elastic:master Jun 7, 2018
@DaveCTurner DaveCTurner deleted the 2018-06-06-multiple-fields-with-one-name branch June 7, 2018 11:39
DaveCTurner added a commit that referenced this pull request Jun 7, 2018
If there is only one type per index then each field's name is unique.
@DaveCTurner
Copy link
Contributor Author

Thanks @jpountz. Merged and backported to 6.x as we discussed.

jasontedor added a commit that referenced this pull request Jun 8, 2018
* elastic/master: (53 commits)
  Painless: Restructure/Clean Up of Spec Documentation (#31013)
  Update ignore_unmapped serialization after backport
  Add back dropped substitution on merge
  high level REST api: cancel task (#30745)
  Enable engine factory to be pluggable (#31183)
  Remove vestiges of animal sniffer (#31178)
  Rename elasticsearch-nio to nio (#31186)
  Rename elasticsearch-core to core (#31185)
  Move cli sub-project out of server to libs (#31184)
  [DOCS] Fixes broken link in auditing settings
  QA: Better seed nodes for rolling restart
  [DOCS] Moves ML content to stack-docs
  [DOCS] Clarifies recommendation for audit index output type (#31146)
  Add nio-transport as option for http smoke tests (#31162)
  QA: Set better node names on rolling restart tests
  Add support for ignore_unmapped to geo sort (#31153)
  Share common parser in some AcknowledgedResponses (#31169)
  Fix random failure on SearchQueryIT#testTermExpansionExceptionOnSpanFailure
  Remove reference to multiple fields with one name (#31127)
  Remove BlobContainer.move() method (#31100)
  ...
jasontedor added a commit that referenced this pull request Jun 8, 2018
* elastic/6.x: (50 commits)
  Painless: Restructure/Clean Up of Spec Documentation (#31013)
  Add support for ignore_unmapped to geo sort (#31153)
  Enable engine factory to be pluggable (#31183)
  Remove vestiges of animal sniffer (#31178)
  Rename elasticsearch-core to core (#31185)
  Move cli sub-project out of server to libs (#31184)
  QA: Fixup rolling restart tests
  QA: Better seed nodes for rolling restart
  [DOCS] Fixes broken link in release notes
  [DOCS] Fixes broken link in auditing settings
  [DOCS] Moves ML content to stack-docs
  [DOCS] Clarifies recommendation for audit index output type (#31146)
  QA: Set better node names on rolling restart tests
  QA: Skip mysterious failing rolling upgrade tests
  Share common parser in some AcknowledgedResponses (#31169)
  Fix random failure on SearchQueryIT#testTermExpansionExceptionOnSpanFailure
  Remove reference to multiple fields with one name (#31127)
  Remove BlobContainer.move() method (#31100)
  [Docs] Correct minor typos in templates.asciidoc (#31167)
  Use ESBlobStoreRepositoryIntegTestCase to test the repository-s3 plugin (#29315)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants