Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Discovery.AckListener.onTimeout() #30514

Merged
merged 2 commits into from
May 10, 2018
Merged

Remove Discovery.AckListener.onTimeout() #30514

merged 2 commits into from
May 10, 2018

Commits on May 10, 2018

  1. Remove Discovery.AckListener.onTimeout() 

    The MasterService takes responsibility for timeouts of the AckListeners that it
creates, and the rest of the Discovery subsystem is unaware of these timeouts,
so there's no need for this to appear in the Discovery.AckListener interface.

Also fix a typo in the name of DelegatingAckListener.
    @DaveCTurner
    DaveCTurner committed May 10, 2018
    Configuration menu
    Copy the full SHA
    d420323 View commit details
    Browse the repository at this point in the history

  2. timeoutOccurred is now always false

    @DaveCTurner
    DaveCTurner committed May 10, 2018
    Configuration menu
    Copy the full SHA
    09e5747 View commit details
    Browse the repository at this point in the history