Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: reduce garbage during index resolution #30180

Merged
merged 4 commits into from
May 3, 2018

Commits on Apr 26, 2018

  1. Security: reduce garbage during index resoltuion

    The IndexAndAliasesResolver resolves the indices and aliases for each
    request and also handles local and remote indices. The current
    implementation uses the ResolvedIndices class to hold the resolved
    indices and aliases. While evaluating the indices and aliases against
    the user's permissions, the final value for ResolvedIndices is
    constructed. Prior to this change, this was done by creating a
    ResolvedIndices for the first set of indices and for each additional
    addition, a new ResolvedIndices object is created and merged with
    the existing one. With a small number of indices and aliases this does
    not pose a large problem; however as the number of indices/aliases
    grows more list allocations and array copies are needed resulting in a
    large amount of garbage and severely impacted performance.
    
    This change introduces a builder for ResolvedIndices that appends to
    mutable lists until the final value has been constructed, which will
    ultimately reduce the amount of garbage generated by this code.
    jaymode committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    6f9c5a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Configuration menu
    Copy the full SHA
    37cb96a View commit details
    Browse the repository at this point in the history
  2. add changelog entry

    jaymode committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    ce5f85d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Configuration menu
    Copy the full SHA
    2f216d9 View commit details
    Browse the repository at this point in the history