Main response should not have status 503 when okay #29045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST status 503 means "I can not handle the request that you sent me." However today we respond to a main request with a 503 when there are certain cluster blocks despite still responding with an actual main response. This is broken, we should respond with a 200 status. This commit removes this silliness.
jasontedor
added
>breaking
review
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
Thanks @martijnvg. |
fatmcgav
pushed a commit
to fatmcgav/helm-charts
that referenced
this pull request
Nov 20, 2019
nodes are available. The behaviour of the `/` endpoint changed[0] between 6.x and 7.x, whereby previously it would return a HTTP `503` response when the cluster was blocked, it now returns a HTTP `200` response even if there are no masters available. This change updates the behaviour of the `readinessProbe` command during normal running to verify that the local node is responding and that there are master nodes available. [1] The desired behaviour here is that if the data nodes are unable to talk to their master nodes for whatever reason, then the data nodes will become `Unready` and therefore be removed from the Service load-balancer until the master nodes are available again. Refs: [0] elastic/elasticsearch#29045 [1] elastic/elasticsearch#34897 (comment)
2 tasks
galina-tochilkin
pushed a commit
to mtp-devops/3d-party-helm
that referenced
this pull request
Dec 20, 2022
nodes are available. The behaviour of the `/` endpoint changed[0] between 6.x and 7.x, whereby previously it would return a HTTP `503` response when the cluster was blocked, it now returns a HTTP `200` response even if there are no masters available. This change updates the behaviour of the `readinessProbe` command during normal running to verify that the local node is responding and that there are master nodes available. [1] The desired behaviour here is that if the data nodes are unable to talk to their master nodes for whatever reason, then the data nodes will become `Unready` and therefore be removed from the Service load-balancer until the master nodes are available again. Refs: [0] elastic/elasticsearch#29045 [1] elastic/elasticsearch#34897 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST status 503 means "I can not handle the request that you sent me." However today we respond to a main request with a 503 when there are certain cluster blocks despite still responding with an actual main response. This is broken, we should respond with a 200 status. This commit removes this silliness.
Closes #8902