Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bound for translog flush threshold #28382

Merged
merged 4 commits into from
Feb 1, 2018

Commits on Jan 25, 2018

  1. Add lower bound for translog flush threshold

    If the translog flush threshold is too small (eg. smaller than the
    translog header), we may repeatedly flush even there is no uncommitted
    operation because the shouldFlush condition can still be true after
    flushing. This is currently avoided by adding an extra guard against the
    uncommitted operations. However, this extra guard makes the shouldFlush
    complicated. This commit replaces that extra guard by a lower bound for
    translog flush threshold. We keep the lower bound small for convenience
    in testing.
    
    Relates elastic#28350
    Relates elastic#23606
    dnhatn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    58a62ab View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Configuration menu
    Copy the full SHA
    6e29520 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    706da9c View commit details
    Browse the repository at this point in the history
  3. Add assertions

    dnhatn committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    4df2538 View commit details
    Browse the repository at this point in the history