Add size-based condition to the index rollover API #27160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to add a `max_size` condition to the index rollover API. We use a `totalSizeInBytes` from `DocsStats` to evaluate this condition. Closes elastic#27004
s1monw
approved these changes
Oct 29, 2017
| * Checks if this condition is available in a specific version. | ||
| * This makes sure BWC when introducing a new condition which is not recognized by older versions. | ||
| */ | ||
| abstract boolean includedInVersion(Version version); |
There was a problem hiding this comment.
maybe just default it to true then you don't need to override it in the existing ones
There was a problem hiding this comment.
@s1monw, I made it abstract to make sure that when we add new conditions, we have to pay attention for BWC. Should I update as you suggested or keep as it is? WDYT?
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 5, 2017
This is to add a max_size condition to the index rollover API. We use a totalSizeInBytes from DocsStats to evaluate this condition. Closes elastic#27004
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 5, 2017
* master: Backport the size-based index rollver to v6.1.0 Add size-based condition to the index rollover API (elastic#27160) Remove the single argument Environment constructor (elastic#27235)
martijnvg
added a commit
that referenced
this pull request
Nov 6, 2017
* 6.x: test: Break apart the multi type aspect of rolling upgrade tests, Upgrade to Jackson 2.8.10 (#27230) [Docs] Fix minor paragraph indentation error for multiple Indices params (#25535) Fix inconsistencies in the rest api specs for `tasks` (#27163) Adjust RestHighLevelClient method modifiers (#27238) Add more information on `_failed_to_convert_` exception (#27034) Remove ElasticsearchQueryCachingPolicy (#27190) Backport the size-based index rollver to v6.1.0 Add size-based condition to the index rollover API (#27160) Remove the single argument Environment constructor (#27235) Fix RestGetAction name typo
clintongormley
added
:Data Management/Indices APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add a
max_sizecondition to the index rollover API. We usea
totalSizeInBytesfromDocsStatsto evaluate this condition.Closes #27004