Filter unsupported relation for RangeQueryBuilder #26620
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@jpountz Thanks! However I didn't find your comment... 😃 |
|
|
||
| public boolean isAllowedInRangeQuery() { | ||
| return this == INTERSECTS || this == CONTAINS || this == WITHIN; | ||
| } |
There was a problem hiding this comment.
It feels a bit wrong to me to make ShapeRelation aware of how it is used in range queries. I'd rather put this logic in RangeQueryBuilder.
There was a problem hiding this comment.
Make sense! Very thanks!
|
I had forgotten to click on the button. :) |
liketic
force-pushed
the
reject-disjoint
branch
from
3b7474c
to
d833f2b
Compare
|
@elasticmachine please test it |
|
@jpountz Please let me know if you plan to merge this so I can resolve the conflicts and squash commits. Thanks very much! 😄 |
|
CI check was successful so I'll merge it today. |
liketic
force-pushed
the
reject-disjoint
branch
from
d833f2b
to
8a6234b
Compare
|
@jpountz rebase done. Thanks! |
jpountz
added
:Search/Search
* master: fix testSniffNodes to use the new error message Add check for invalid index in WildcardExpressionResolver (elastic#26409) Docs: Use single-node discovery.type for dev example Filter unsupported relation for range query builder (elastic#26620) Fix kuromoji default stoptags (elastic#26600) [Docs] Add description for missing fields in Reindex/Update/Delete By Query (elastic#26618) [Docs] Update ingest.asciidoc (elastic#26599) Better message text for ResponseException [DOCS] Remove edit link from ML node enable bwc testing fix StartRecoveryRequestTests.testSerialization Add bad_request to the rest-api-spec catch params (elastic#26539) Introduce a History UUID as a requirement for ops based recovery (elastic#26577) Add missing catch arguments to the rest api spec (elastic#26536)
Closes #26575
@jpountz Please help to review. Happy to make further changes. Thanks.