[DOCS] Update shared attributes for Elasticsearch #25479
Conversation
|
@debadair If we eventually want to use the shared attributes from books other than the Elasticsearch Reference (e.g. from the Painless and client books), we can move the "include::{docs-dir}/shared/attributes.asciidoc[]" from index-shared1.asciidoc to Versions.asciidoc. I haven't done any work on those other books at this point. |
|
BTW, I'd be inclined to pull the attributes for the definitive guide and painless and plugins docs into the shared file, as well. |
lcawl
force-pushed
the
lcawley-sharedattrs
branch
from
20f4f2e
to
0614e25
Compare
lcawl
force-pushed
the
lcawley-sharedattrs
branch
from
0614e25
to
95926c0
Compare
|
@debadair verified that the other books were okay to use the shared attributes, so I moved the reference to the elastic/docs/shared/attributes.asciidoc from index-shared1.asciidoc to Versions.asciidoc. I also moved the definitive guide, painless, and plugins doc URLs to the shared file too. |
|
LGTM |
* [DOCS] Update shared attributes for Elasticsearch * [DOCS] Moved shared attributes to Versions.asciidoc * [DOCS] More more book URLs to shared attributes
* [DOCS] Update shared attributes for Elasticsearch * [DOCS] Moved shared attributes to Versions.asciidoc * [DOCS] More more book URLs to shared attributes
|
Thanks! I've retrofitted to 5.x and 5.5 |
* master: (129 commits) Add doc note regarding explicit publish host Fix typo in name of test Add additional test for sequence-number recovery WrapperQueryBuilder should also rewrite the parsed query. Remove dead code and stale Javadoc Update defaults in documentation (#25483) [DOCS] Add docs-dir to Painless (#25482) Add concurrent deprecation logger test [DOCS] Update shared attributes for Elasticsearch (#25479) Use LRU set to reduce repeat deprecation messages Add NioTransport threads to thread name checks (#25477) Add shortcut for AbstractQueryBuilder.parseInnerQueryBuilder to QueryShardContext Prevent channel enqueue after selector close (#25478) Fix Java 9 compilation issue Remove unregistered `transport.netty.*` settings (#25476) Handle ping correctly in NioTransport (#25462) Tests: Remove platform specific assertion in NioSocketChannelTests Remove QueryParseContext from parsing QueryBuilders (#25448) Promote replica on the highest version node (#25277) test: added not null assertion ...
This pull request removes shared attributes from the Versions.asciidoc file and instead adds a reference to the list of shared attributes in the elastic/docs/shared repository.