Cleanup some things after removal of joda-time hack #18959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| urlElements[i] = PathUtils.get(element).toUri().toURL(); | ||
| URL url = PathUtils.get(element).toUri().toURL(); | ||
| if (urlElements.add(url) == false) { | ||
| throw new IllegalStateException("jar hell!" + System.lineSeparator() + |
|
LGTM left some minors |
clintongormley
added
>enhancement
:Delivery/Packaging
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 15, 2017
After the removal of the joda time hack we used to have, we can cleanup the codebase handling in security, jarhell and plugins to be more picky about uniqueness. This was originally in elastic#18959 which was never merged. closes elastic#18959
rjernst
added a commit
that referenced
this pull request
Mar 21, 2017
rjernst
added a commit
that referenced
this pull request
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing this hack, we can cleanup a bit. Particularly important is to be able to treat codebases as a unique thing (since ES jar is no longer duplicated on the classpath to be "in front of" joda-time). This gives a lot of internal checks in case something goes wrong.
I know the other day i accidentally installed groovy as a plugin (its already a module), and the error was strange. So using Set and checking the return values is an easy improvement.