Add the ability to use the breadth_first mode with nested aggregations (such as top_hits) which require access to score information.
#18127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpountz I misunderstood how the DeferringBucketCollector works especially this part: This means that we don't need to make it smarter ;). |
| final PackedLongValues.Iterator docDeltaIterator = entry.docDeltas.iterator(); | ||
| final PackedLongValues.Iterator buckets = entry.buckets.iterator(); | ||
| int doc = 0; | ||
| for (long i = 0, end = entry.docDeltas.size(); i < end; ++i) { | ||
| doc += docDeltaIterator.next(); | ||
| if (needsScores) { | ||
| docIt.advance(doc); |
There was a problem hiding this comment.
calling docIt.advance(doc) is illegal if the scorer is already positioned on doc, so it should be something like:
if (docIt.docId() < doc) {
docIt.advance(doc);
}
assert docIt.doc() == doc; // aggregations should only be replayed on matching documents
|
Thanks @jimferenczi. I left some comments. |
|
LGTM |
…s (such as `top_hits`) which require access to score information. The score is recomputed lazily for each document belonging to a top bucket. Relates to #9825
clintongormley
added
>enhancement
:Analytics/Aggregations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The score is recomputed lazily for each document belonging to a top bucket.
Relates to #9825