Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During ML maintenance, reset jobs in the reset state without a corresponding task. #106062

Merged
merged 4 commits into from
Mar 8, 2024
Merged

During ML maintenance, reset jobs in the reset state without a corresponding task. #106062

merged 4 commits into from
Mar 8, 2024
+218 −105

Conversation

jan-elastic
Copy link
Contributor

Item 2 of #105928

@jan-elastic jan-elastic added >bug :ml Machine learning Team:ML Meta label for the ML team auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.13.0 v8.14.0 labels Mar 7, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @jan-elastic, I've created a changelog YAML for you.

droberts195
droberts195 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm happy for this to be merged without further review, but first please consider whether the test should be closer to how it was before to prevent occasional failures.

x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/MlDailyMaintenanceServiceTests.java Show resolved Hide resolved
davidkyle
davidkyle approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for cleaning up the tests

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlDailyMaintenanceService.java Outdated Show resolved Hide resolved
@jan-elastic jan-elastic merged commit 24228cd into main Mar 8, 2024
15 checks passed
@jan-elastic jan-elastic deleted the ml-maintenance-reset-jobs branch March 8, 2024 13:49
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 106062

jan-elastic added a commit that referenced this pull request Mar 8, 2024
@jan-elastic
During ML maintenance, reset jobs in the reset state without a corres…
14f7151 
…ponding task. (#106062)

* During ML maintenance, reset jobs in the reset state without a corresponding task.

* Update docs/changelog/106062.yaml

* Fix race condition in MlDailyMaintenanceServiceTests

* Fix log level
@jan-elastic jan-elastic mentioned this pull request Mar 8, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Mar 8, 2024
@jan-elastic
During ML maintenance, reset jobs in the reset state without a corres…
4757b89 
…ponding task. (#106062) (#106125)

* During ML maintenance, reset jobs in the reset state without a corresponding task.

* Update docs/changelog/106062.yaml

* Fix race condition in MlDailyMaintenanceServiceTests

* Fix log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready backport pending >bug :ml Machine learning Team:ML Meta label for the ML team v8.13.0 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jan-elastic @elasticsearchmachine @davidkyle @droberts195