Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset job if existing reset fails #106020

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

jan-elastic
Copy link
Contributor

This implements the item 1 of #105928.

@jan-elastic jan-elastic added >bug :ml Machine learning v8.14.0 labels Mar 6, 2024
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Mar 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @jan-elastic, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@droberts195 droberts195 added auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.13.0 labels Mar 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @jan-elastic, I've updated the changelog YAML for you.

@jan-elastic
Copy link
Contributor Author

Thanks for the review. Fixed all your comments. PTAL

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-elastic jan-elastic merged commit fb0fc30 into main Mar 7, 2024
15 checks passed
@jan-elastic jan-elastic deleted the reset-job-if-existing-reset-failed branch March 7, 2024 09:07
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 106020

jan-elastic added a commit that referenced this pull request Mar 7, 2024
* Try again to reset a job if waiting for completion of an existing reset task fails.

* Update docs/changelog/106020.yaml

* Update 106020.yaml

* Update docs/changelog/106020.yaml

* Improve code
@jan-elastic jan-elastic mentioned this pull request Mar 7, 2024
elasticsearchmachine pushed a commit that referenced this pull request Mar 7, 2024
* Reset job if existing reset fails (#106020)

* Try again to reset a job if waiting for completion of an existing reset task fails.

* Update docs/changelog/106020.yaml

* Update 106020.yaml

* Update docs/changelog/106020.yaml

* Improve code

* Trigger rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready backport pending >bug :ml Machine learning Team:ML Meta label for the ML team v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants