[ML] Fix AutodetectMemoryLimitIT.testManyDistinctOverFields #105727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the changes of elastic/ml-cpp#2585 combined with the randomness of the test could cause it to fail very occasionally, and by a tiny percentage over the expected upper bound. This change reenables the test by very slightly increasing the upper bound. Fixes elastic#105347
droberts195
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Feb 22, 2024
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Feb 22, 2024
…105727) It seems that the changes of elastic/ml-cpp#2585 combined with the randomness of the test could cause it to fail very occasionally, and by a tiny percentage over the expected upper bound. This change reenables the test by very slightly increasing the upper bound. Fixes elastic#105347
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2024
…#105734) It seems that the changes of elastic/ml-cpp#2585 combined with the randomness of the test could cause it to fail very occasionally, and by a tiny percentage over the expected upper bound. This change reenables the test by very slightly increasing the upper bound. Fixes #105347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the changes of elastic/ml-cpp#2585 combined with the randomness of the test could cause it to fail very occasionally, and by a tiny percentage over the expected upper bound. This change reenables the test by very slightly increasing the upper bound.
Fixes #105347