Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ML] Use perAllocation and perDeployment memory usage in the model assignment planner" #101834

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

valeriy42
Copy link
Contributor

There were a number of BWC test failures after the PR was merged today. I'll revert it and investigate the failures locally.

Reverts #98874

@elasticsearchmachine elasticsearchmachine added v8.12.0 needs:triage Requires assignment of a team area label labels Nov 6, 2023
@valeriy42 valeriy42 added :ml Machine learning Team:ML Meta label for the ML team and removed needs:triage Requires assignment of a team area label v8.12.0 labels Nov 6, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@valeriy42 valeriy42 added v8.12.0 >test-failure Triaged test failures from CI labels Nov 6, 2023
@valeriy42 valeriy42 merged commit 63f29d4 into main Nov 6, 2023
13 of 14 checks passed
@valeriy42 valeriy42 deleted the revert-98874-update-assignment-planner branch November 6, 2023 15:54
valeriy42 added a commit that referenced this pull request Nov 7, 2023
…in the model assignment planner" (#101853)

The original PR #98874 missed the memory overhead adjustment from #86416. As it caused some BWC test failures on the CI, I reverted it in #101834.

This PR reintegrates the functionality and extends the BWC integration test with the memory constant depending on the version of the old cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker :ml Machine learning Team:ML Meta label for the ML team >test-failure Triaged test failures from CI v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants