Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET _cat/nodes?local is not completely local #50088

Closed
DaveCTurner opened this issue Dec 11, 2019 · 5 comments
Closed

GET _cat/nodes?local is not completely local #50088

DaveCTurner opened this issue Dec 11, 2019 · 5 comments
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat good first issue low hanging fruit help wanted adoptme

Comments

@DaveCTurner
Copy link
Contributor

The cat nodes API performs a ClusterStateAction then a NodesInfoAction. It accepts the ?local parameter and passes this to the ClusterStateAction but this parameter has no effect on the NodesInfoAction. This is surprising, because GET _cat/nodes?local looks like it might be a completely local call but in fact it still depends on every node in the cluster.

I think the ?local parameter does not make sense on this API and we should remove it.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

@DaveCTurner DaveCTurner mentioned this issue Dec 11, 2019
Closed
@DaveCTurner
Copy link
Contributor Author

We discussed this as a team today and agreed to deprecate the ?local parameter to GET _cat/nodes in 7.x and remove it in 8.0.

@DaveCTurner DaveCTurner added help wanted adoptme good first issue low hanging fruit and removed discuss labels Dec 13, 2019
@jpountz jpountz mentioned this issue Dec 13, 2019
Open
@olegbonar
Copy link
Contributor

Hi @DaveCTurner! May I work on this one? Any hints are appreciated.

@DaveCTurner
Copy link
Contributor Author

Sure, go ahead. See e.g. #49458 for another example of how to deprecate something properly.

@olegbonar olegbonar mentioned this issue Dec 26, 2019
Merged
DaveCTurner pushed a commit that referenced this issue Jan 2, 2020
@olegbonar @DaveCTurner
Deprecate the 'local' parameter of /_cat/nodes (#50499)
1c24921 
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This commit deprecates the `?local` parameter on this API so that it can be
removed in 8.0.

Relates #50088
DaveCTurner pushed a commit that referenced this issue Jan 2, 2020
@olegbonar @DaveCTurner
Deprecate the 'local' parameter of /_cat/nodes (#50499)
7539fbb 
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This commit deprecates the `?local` parameter on this API so that it can be
removed in 8.0.

Relates #50088
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Jan 3, 2020
@DaveCTurner
Remove the 'local' parameter of /_cat/nodes
80f0241 
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This parameter was deprecated in 7.x in elastic#50499 and this commit removes it.

Relates elastic#50088
@DaveCTurner DaveCTurner mentioned this issue Jan 3, 2020
Merged
DaveCTurner added a commit that referenced this issue Jan 6, 2020
@DaveCTurner
Remove the 'local' parameter of /_cat/nodes (#50594)
8c6f821 
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This parameter was deprecated in 7.x in #50499 and this commit removes it.

Relates #50088
@DaveCTurner
Copy link
Contributor Author

Closed by #50594 and #50499.

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@olegbonar @SivagurunathanV
Deprecate the 'local' parameter of /_cat/nodes (elastic#50499)
5f981c1 
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This commit deprecates the `?local` parameter on this API so that it can be
removed in 8.0.

Relates elastic#50088
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@DaveCTurner @SivagurunathanV
Remove the 'local' parameter of /_cat/nodes (elastic#50594)
8cce978 
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This parameter was deprecated in 7.x in elastic#50499 and this commit removes it.

Relates elastic#50088
This was referenced Feb 3, 2020
Closed
Closed
@DaveCTurner DaveCTurner mentioned this issue Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat good first issue low hanging fruit help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DaveCTurner @elasticmachine @olegbonar