Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Failing Group By queries due to different ExpressionIds #42041

Closed
8 tasks done
matriv opened this issue May 9, 2019 · 1 comment · Fixed by #43072
Closed
8 tasks done

SQL: Failing Group By queries due to different ExpressionIds #42041

matriv opened this issue May 9, 2019 · 1 comment · Fixed by #43072
Labels
:Analytics/SQL SQL querying >bug Meta

Comments

@matriv
Copy link
Contributor

matriv commented May 9, 2019 •
edited
Loading

This is a meta issue to track the Group By queries that fail in the QueryFolder
because of the different ExpressionIds which results in not being able to find
the same expression in the groupingContext map.
@matriv matriv added Meta :Analytics/SQL SQL querying labels May 9, 2019
emasab added a commit to emasab/elasticsearch that referenced this issue Oct 28, 2019
@emasab
bugfix for elastic#42041
760b65a
@matriv matriv added the >bug label Oct 29, 2019
@emasab emasab mentioned this issue Oct 29, 2019
Merged
matriv pushed a commit that referenced this issue Oct 31, 2019
@emasab @matriv
SQL: Failing Group By queries due to different ExpressionIds (#43072)
3c38ea5 
Fix an issue that arises from the use of ExpressionIds as keys in a lookup map
that helps the QueryTranslator to identify the grouping columns. The issue is
that the same expression in different parts of the query (SELECT clause and GROUP BY clause)
ends up with different ExpressionIds so the lookup fails. So, instead of ExpressionIds
use the hashCode() of NamedExpression.

Fixes: #41159
Fixes: #40001
Fixes: #40240
Fixes: #33361
Fixes: #46316
Fixes: #36074
Fixes: #34543
Fixes: #37044

Fixes: #42041
matriv pushed a commit that referenced this issue Oct 31, 2019
@emasab @matriv
SQL: Failing Group By queries due to different ExpressionIds (#43072)
185e067 
Fix an issue that arises from the use of ExpressionIds as keys in a lookup map
that helps the QueryTranslator to identify the grouping columns. The issue is
that the same expression in different parts of the query (SELECT clause and GROUP BY clause)
ends up with different ExpressionIds so the lookup fails. So, instead of ExpressionIds
use the hashCode() of NamedExpression.

Fixes: #41159
Fixes: #40001
Fixes: #40240
Fixes: #33361
Fixes: #46316
Fixes: #36074
Fixes: #34543
Fixes: #37044

Fixes: #42041
(cherry picked from commit 3c38ea5)
matriv pushed a commit that referenced this issue Oct 31, 2019
@emasab @matriv
SQL: Failing Group By queries due to different ExpressionIds (#43072)
6d71682 
Fix an issue that arises from the use of ExpressionIds as keys in a lookup map
that helps the QueryTranslator to identify the grouping columns. The issue is
that the same expression in different parts of the query (SELECT clause and GROUP BY clause)
ends up with different ExpressionIds so the lookup fails. So, instead of ExpressionIds
use the hashCode() of NamedExpression.

Fixes: #41159
Fixes: #40001
Fixes: #40240
Fixes: #33361
Fixes: #46316
Fixes: #36074
Fixes: #34543
Fixes: #37044

Fixes: #42041
(cherry picked from commit 3c38ea5)
matriv pushed a commit that referenced this issue Oct 31, 2019
@emasab @matriv
SQL: Failing Group By queries due to different ExpressionIds (#43072)
bcbba30 
Fix an issue that arises from the use of ExpressionIds as keys in a lookup map
that helps the QueryTranslator to identify the grouping columns. The issue is
that the same expression in different parts of the query (SELECT clause and GROUP BY clause)
ends up with different ExpressionIds so the lookup fails. So, instead of ExpressionIds
use the hashCode() of NamedExpression.

Fixes: #41159
Fixes: #40001
Fixes: #40240
Fixes: #33361
Fixes: #46316
Fixes: #36074
Fixes: #34543
Fixes: #37044

Fixes: #42041
(cherry picked from commit 3c38ea5)
matriv pushed a commit that referenced this issue Oct 31, 2019
@emasab @matriv
SQL: Failing Group By queries due to different ExpressionIds (#43072)
a759375 
Fix an issue that arises from the use of ExpressionIds as keys in a lookup map
that helps the QueryTranslator to identify the grouping columns. The issue is
that the same expression in different parts of the query (SELECT clause and GROUP BY clause)
ends up with different ExpressionIds so the lookup fails. So, instead of ExpressionIds
use the hashCode() of NamedExpression.

Fixes: #41159
Fixes: #40001
Fixes: #40240
Fixes: #33361
Fixes: #46316
Fixes: #36074
Fixes: #34543
Fixes: #37044

Fixes: #42041
(cherry picked from commit 3c38ea5)
@matriv
Copy link
Contributor Author

matriv commented Oct 31, 2019

master : 3c38ea5
7.x : 185e067
7.5 : 6d71682
7.4 : bcbba30
6.8 : a759375

This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Failing Group By queries due to different ExpressionIds emasab/elasticsearch
1 participant
@matriv