Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] SmokeTestWatcherClientYamlTestSuiteIT "Test Jira Action with Error" failure #30705

Closed
rjernst opened this issue May 17, 2018 · 3 comments · Fixed by #35271
Closed

[CI] SmokeTestWatcherClientYamlTestSuiteIT "Test Jira Action with Error" failure #30705

rjernst opened this issue May 17, 2018 · 3 comments · Fixed by #35271
Assignees
@hub-cap @spinscale
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI

Comments

@rjernst
Copy link
Member

rjernst commented May 17, 2018

This test fails periodically because watcher is not started. This is likely because the node is considered green even when watcher is not started. So on a slow node, the test could start before watcher gets to the started state.

https://internal-ci.elastic.co/job/elastic+x-pack-elasticsearch+5.6+multijob-unix-compatibility/1568/console
@rjernst rjernst added >test-failure Triaged test failures from CI :Data Management/Watcher labels May 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member Author

rjernst commented May 17, 2018

Note that this test was moved to x-pack/qa/third-party/jira.

@hub-cap
Copy link
Contributor

hub-cap commented Aug 14, 2018

is it valid to think that a node is green before its plugins have finished starting up? This obviously does not pertain to only watcher, but watcher def has a bunch of internals that take some time to "wake up and start". Does it make sense to not allow the node to be green until this is the case?

@jakelandis jakelandis mentioned this issue Nov 5, 2018
Merged
jakelandis added a commit that referenced this issue Nov 7, 2018
@jakelandis
watcher: Fix integration tests to ensure correct start/stop of Watcher (
d7a4cef 
#35271)

Ensure that Watcher is correctly started and stopped between tests for
SmokeTestWatcherWithSecurityIT,
SmokeTestWatcherWithSecurityClientYamlTestSuiteIT,
SmokeTestWatcherTestSuiteIT, WatcherRestIT,
XDocsClientYamlTestSuiteIT, and XPackRestIT

The change here is to throw an `AssertionError` instead of `break;` to
allow the `assertBusy()` to continue to busy wait until the desired
state is reached.

closes #33291, closes #29877, closes #34462, closes #30705, closes #34448
jakelandis added a commit that referenced this issue Nov 8, 2018
@jakelandis
watcher: Fix integration tests to ensure correct start/stop of Watcher (
bf8e4b7 
#35271)

Ensure that Watcher is correctly started and stopped between tests for
SmokeTestWatcherWithSecurityIT,
SmokeTestWatcherWithSecurityClientYamlTestSuiteIT,
SmokeTestWatcherTestSuiteIT, WatcherRestIT,
XDocsClientYamlTestSuiteIT, and XPackRestIT

The change here is to throw an `AssertionError` instead of `break;` to
allow the `assertBusy()` to continue to busy wait until the desired
state is reached.

closes #33291, closes #29877, closes #34462, closes #30705, closes #34448
jakelandis added a commit that referenced this issue Nov 8, 2018
@jakelandis
watcher: Fix integration tests to ensure correct start/stop of Watcher (
a3b2c72 
#35271)

Ensure that Watcher is correctly started and stopped between tests for
SmokeTestWatcherWithSecurityIT,
SmokeTestWatcherWithSecurityClientYamlTestSuiteIT,
SmokeTestWatcherTestSuiteIT, WatcherRestIT,
XDocsClientYamlTestSuiteIT, and XPackRestIT

The change here is to throw an `AssertionError` instead of `break;` to
allow the `assertBusy()` to continue to busy wait until the desired
state is reached.

closes #33291, closes #29877, closes #34462, closes #30705, closes #34448
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this issue Nov 13, 2018
@jakelandis @pgomulka
watcher: Fix integration tests to ensure correct start/stop of Watcher (
930ef46 
elastic#35271)

Ensure that Watcher is correctly started and stopped between tests for
SmokeTestWatcherWithSecurityIT,
SmokeTestWatcherWithSecurityClientYamlTestSuiteIT,
SmokeTestWatcherTestSuiteIT, WatcherRestIT,
XDocsClientYamlTestSuiteIT, and XPackRestIT

The change here is to throw an `AssertionError` instead of `break;` to
allow the `assertBusy()` to continue to busy wait until the desired
state is reached.

closes elastic#33291, closes elastic#29877, closes elastic#34462, closes elastic#30705, closes elastic#34448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hub-cap hub-cap

@spinscale spinscale

Labels
:Data Management/Watcher >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

watcher: Fix integration tests to ensure correct start/stop of Watcher jakelandis/elasticsearch
4 participants
@rjernst @hub-cap @spinscale @elasticmachine