-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot azure repository support for Azure China #26432
Labels
Comments
Hi @dadoonet Are you working on this? I'm happy to take this. :) |
I'm not. Feel free to take it and send your PR. Thanks! |
rjernst
pushed a commit
that referenced
this issue
Sep 21, 2017
rjernst
pushed a commit
that referenced
this issue
Sep 21, 2017
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this issue
Sep 21, 2017
* master: Add permission checks before reading from HDFS stream (elastic#26716) muted test [Docs] Fixed typo of *configuration* (elastic#25058) Add azure storage endpoint suffix elastic#26432 (elastic#26568)
clintongormley
added
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
and removed
:Plugin Repository Azure
labels
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the feature:
The azure snapshot plugin currently takes a storage account name and key as an input and tries to retrieve the CloudStorageAccount by forming a connection string via the provided input. The domain in the default case is assumed to be 'core.windows.net' which works for most of Microsoft's data centers.
In China, the domain is different, hence trying to store/restore a snapshot by using the storage account name and key alone as inputs does not work. The storage account access keys provide an EndpointSuffix attribute which indicates the domain to be used. As a feature, it will be nice to have an additional input attribute for the Endpoint Suffix with the default still being 'core.windows.net' if left unspecified.
We currently are running ES1.6 in china for our prod customers. In order to circumvent this, we had to include the EndpointSuffix portion as part of the account key input value since the connection string is formed through concatenation. It will be nice to have this as an explicit input.
Elasticsearch version (
bin/elasticsearch --version
): 1.6.2The text was updated successfully, but these errors were encountered: