Copy TimingStats to prevent it being modified outside of JobStats bui…

…lder
elastic · Jun 11, 2019 · dc385ac · dc385ac
1 parent 64b7725
commit dc385ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.../main/java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParams.java b/.../main/java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParams.java
@@ -136,7 +136,7 @@ public Builder setModelSizeStats(ModelSizeStats modelSizeStats) {
         }
 
         public Builder setTimingStats(TimingStats timingStats) {
-            this.timingStats = timingStats;
+            this.timingStats = new TimingStats(timingStats);
             return this;
         }
 

diff --git a/.../java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParamsTests.java b/.../java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParamsTests.java
@@ -18,6 +18,10 @@ public void testBuilder_WithTimingStats() {
         TimingStats timingStats = new TimingStats(JOB_ID, 7, 1.0, 1000.0, 666.0);
         AutodetectParams params = new AutodetectParams.Builder(JOB_ID).setTimingStats(timingStats).build();
         assertThat(params.timingStats(), equalTo(timingStats));
+
+        timingStats.updateStats(2000.0);
+        assertThat(timingStats, equalTo(new TimingStats(JOB_ID, 8, 1.0, 2000.0, 832.75)));
+        assertThat(params.timingStats(), equalTo(new TimingStats(JOB_ID, 7, 1.0, 1000.0, 666.0)));
     }
 
     public void testBuilder_WithoutTimingStats() {