-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce retention lease syncing (#37398)
This commit introduces retention lease syncing from the primary to its replicas when a new retention lease is added. A follow-up commit will add a background sync of the retention leases as well so that renewed retention leases are synced to replicas.
- Loading branch information
1 parent
cb13447
commit 5fddb63
Showing
24 changed files
with
855 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
206 changes: 206 additions & 0 deletions
206
server/src/main/java/org/elasticsearch/index/seqno/RetentionLeaseSyncAction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,206 @@ | ||
/* | ||
* Licensed to Elasticsearch under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.elasticsearch.index.seqno; | ||
|
||
import org.apache.logging.log4j.LogManager; | ||
import org.apache.logging.log4j.Logger; | ||
import org.apache.logging.log4j.message.ParameterizedMessage; | ||
import org.apache.lucene.store.AlreadyClosedException; | ||
import org.elasticsearch.ExceptionsHelper; | ||
import org.elasticsearch.action.ActionListener; | ||
import org.elasticsearch.action.admin.indices.flush.FlushRequest; | ||
import org.elasticsearch.action.support.ActionFilters; | ||
import org.elasticsearch.action.support.WriteResponse; | ||
import org.elasticsearch.action.support.replication.ReplicatedWriteRequest; | ||
import org.elasticsearch.action.support.replication.ReplicationResponse; | ||
import org.elasticsearch.action.support.replication.TransportWriteAction; | ||
import org.elasticsearch.cluster.action.shard.ShardStateAction; | ||
import org.elasticsearch.cluster.metadata.IndexNameExpressionResolver; | ||
import org.elasticsearch.cluster.service.ClusterService; | ||
import org.elasticsearch.common.inject.Inject; | ||
import org.elasticsearch.common.io.stream.StreamInput; | ||
import org.elasticsearch.common.io.stream.StreamOutput; | ||
import org.elasticsearch.common.settings.Settings; | ||
import org.elasticsearch.common.util.concurrent.ThreadContext; | ||
import org.elasticsearch.index.shard.IndexShard; | ||
import org.elasticsearch.index.shard.IndexShardClosedException; | ||
import org.elasticsearch.index.shard.ShardId; | ||
import org.elasticsearch.indices.IndicesService; | ||
import org.elasticsearch.threadpool.ThreadPool; | ||
import org.elasticsearch.transport.TransportService; | ||
|
||
import java.io.IOException; | ||
import java.util.Collection; | ||
import java.util.Objects; | ||
|
||
/** | ||
* Write action responsible for syncing retention leases to replicas. This action is deliberately a write action so that if a replica misses | ||
* a retention lease sync then that shard will be marked as stale. | ||
*/ | ||
public class RetentionLeaseSyncAction extends | ||
TransportWriteAction<RetentionLeaseSyncAction.Request, RetentionLeaseSyncAction.Request, RetentionLeaseSyncAction.Response> { | ||
|
||
public static String ACTION_NAME = "indices:admin/seq_no/retention_lease_sync"; | ||
|
||
private static final Logger LOGGER = LogManager.getLogger(RetentionLeaseSyncAction.class); | ||
|
||
protected Logger getLogger() { | ||
return LOGGER; | ||
} | ||
|
||
@Inject | ||
public RetentionLeaseSyncAction( | ||
final Settings settings, | ||
final TransportService transportService, | ||
final ClusterService clusterService, | ||
final IndicesService indicesService, | ||
final ThreadPool threadPool, | ||
final ShardStateAction shardStateAction, | ||
final ActionFilters actionFilters, | ||
final IndexNameExpressionResolver indexNameExpressionResolver) { | ||
super( | ||
settings, | ||
ACTION_NAME, | ||
transportService, | ||
clusterService, | ||
indicesService, | ||
threadPool, | ||
shardStateAction, | ||
actionFilters, | ||
indexNameExpressionResolver, | ||
RetentionLeaseSyncAction.Request::new, | ||
RetentionLeaseSyncAction.Request::new, | ||
ThreadPool.Names.MANAGEMENT); | ||
} | ||
|
||
/** | ||
* Sync the specified retention leases for the specified shard. The callback is invoked when the sync succeeds or fails. | ||
* | ||
* @param shardId the shard to sync | ||
* @param retentionLeases the retention leases to sync | ||
* @param listener the callback to invoke when the sync completes normally or abnormally | ||
*/ | ||
public void syncRetentionLeasesForShard( | ||
final ShardId shardId, | ||
final Collection<RetentionLease> retentionLeases, | ||
final ActionListener<ReplicationResponse> listener) { | ||
Objects.requireNonNull(shardId); | ||
Objects.requireNonNull(retentionLeases); | ||
Objects.requireNonNull(listener); | ||
final ThreadContext threadContext = threadPool.getThreadContext(); | ||
try (ThreadContext.StoredContext ignore = threadContext.stashContext()) { | ||
// we have to execute under the system context so that if security is enabled the sync is authorized | ||
threadContext.markAsSystemContext(); | ||
execute( | ||
new RetentionLeaseSyncAction.Request(shardId, retentionLeases), | ||
ActionListener.wrap( | ||
listener::onResponse, | ||
e -> { | ||
if (ExceptionsHelper.unwrap(e, AlreadyClosedException.class, IndexShardClosedException.class) == null) { | ||
getLogger().warn(new ParameterizedMessage("{} retention lease sync failed", shardId), e); | ||
} | ||
listener.onFailure(e); | ||
})); | ||
} | ||
} | ||
|
||
@Override | ||
protected WritePrimaryResult<Request, Response> shardOperationOnPrimary(final Request request, final IndexShard primary) { | ||
Objects.requireNonNull(request); | ||
Objects.requireNonNull(primary); | ||
// we flush to ensure that retention leases are committed | ||
flush(primary); | ||
return new WritePrimaryResult<>(request, new Response(), null, null, primary, logger); | ||
} | ||
|
||
@Override | ||
protected WriteReplicaResult<Request> shardOperationOnReplica(final Request request, final IndexShard replica) { | ||
Objects.requireNonNull(request); | ||
Objects.requireNonNull(replica); | ||
replica.updateRetentionLeasesOnReplica(request.getRetentionLeases()); | ||
// we flush to ensure that retention leases are committed | ||
flush(replica); | ||
return new WriteReplicaResult<>(request, null, null, replica, logger); | ||
} | ||
|
||
private void flush(final IndexShard indexShard) { | ||
final FlushRequest flushRequest = new FlushRequest(); | ||
flushRequest.force(true); | ||
flushRequest.waitIfOngoing(true); | ||
indexShard.flush(flushRequest); | ||
} | ||
|
||
public static final class Request extends ReplicatedWriteRequest<Request> { | ||
|
||
private Collection<RetentionLease> retentionLeases; | ||
|
||
public Collection<RetentionLease> getRetentionLeases() { | ||
return retentionLeases; | ||
} | ||
|
||
public Request() { | ||
|
||
} | ||
|
||
public Request(final ShardId shardId, final Collection<RetentionLease> retentionLeases) { | ||
super(Objects.requireNonNull(shardId)); | ||
this.retentionLeases = Objects.requireNonNull(retentionLeases); | ||
} | ||
|
||
@Override | ||
public void readFrom(final StreamInput in) throws IOException { | ||
super.readFrom(in); | ||
retentionLeases = in.readList(RetentionLease::new); | ||
} | ||
|
||
@Override | ||
public void writeTo(final StreamOutput out) throws IOException { | ||
super.writeTo(Objects.requireNonNull(out)); | ||
out.writeCollection(retentionLeases); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return "Request{" + | ||
"retentionLeases=" + retentionLeases + | ||
", shardId=" + shardId + | ||
", timeout=" + timeout + | ||
", index='" + index + '\'' + | ||
", waitForActiveShards=" + waitForActiveShards + | ||
'}'; | ||
} | ||
|
||
} | ||
|
||
public static final class Response extends ReplicationResponse implements WriteResponse { | ||
|
||
@Override | ||
public void setForcedRefresh(final boolean forcedRefresh) { | ||
// ignore | ||
} | ||
|
||
} | ||
|
||
@Override | ||
protected Response newResponseInstance() { | ||
return new Response(); | ||
} | ||
|
||
} |
Oops, something went wrong.