Skip to content

Commit

Permalink
Delete reindex exception change todos (#49271)
Browse files Browse the repository at this point in the history
This is related to #42612. This commit deletes TODOs related to test
assertions changing due to exception serialization changes. We have
determined that the exception x-content serialization was never stable
in the first place (reading from the task index), so we are okay with
these changes.
  • Loading branch information
Tim-Brooks committed Nov 20, 2019
1 parent cd51833 commit 476eeb7
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@
- match: {failures.0.index: dest}
- match: {failures.0.id: "1"}
- match: {failures.0.status: 409}
# TODO: Changed the message because of exception serialization
- match: {failures.0.cause.type: exception}
# Use a regex so we don't mind if the version isn't always 1. Sometimes it comes out 2.
- match: {failures.0.cause.reason: "/\\[1\\]:.version.conflict,.document.already.exists.\\(current.version.\\[\\d+\\]\\)/"}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@
source: throw new IllegalArgumentException("Cats!")
dest:
index: dest
# TODO: revisit this once we keep original type.
- match: {error.root_cause.0.type: exception}
# TODO: revisit this once we keep original reason message.
- match: {error.root_cause.0.reason: "Elasticsearch exception [type=search_phase_execution_exception, reason=Partial shards failure]"}
- match: {error.root_cause.0.phase: query}
- match: {error.type: status_exception}
- match: {error.reason: "Elasticsearch exception [type=search_phase_execution_exception, reason=Partial shards failure]"}
# TODO: we kind of change the response format here, but we never documented this so OK?
Original file line number Diff line number Diff line change
Expand Up @@ -439,5 +439,4 @@
script:
lang: painless
source: syntax errors are fun!
# TODO: Changed the message because of exception serialization
- match: {error.reason: 'Elasticsearch exception [type=script_exception, reason=compile error]'}

0 comments on commit 476eeb7

Please sign in to comment.