Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles to cluster.allocation_explain response #2874

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 6, 2024

As done in elastic/elasticsearch#98550. The remaining failure is a NEST test that will be removed.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
cluster.allocation_explain 🔴 5/5 4/5

You can validate this API yourself by using the make validate target.

1 similar comment
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
cluster.allocation_explain 🔴 5/5 4/5

You can validate this API yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
cluster.allocation_explain 🔴 5/5 4/5

You can validate this API yourself by using the make validate target.

@l-trotta
Copy link
Contributor

l-trotta commented Sep 9, 2024

In the spec we have NodeRoles that is an alias for NodeRole[], to be coherent with the other uses I'd keep using it

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
cluster.allocation_explain 🟢 4/4 4/4

You can validate this API yourself by using the make validate target.

@pquentin
Copy link
Member Author

pquentin commented Sep 9, 2024

Thanks, done!

@pquentin pquentin merged commit 3dc9de9 into main Sep 9, 2024
6 checks passed
@pquentin pquentin deleted the allocation-explain-response branch September 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants