-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break function_score out into single- and multi-function types #2852
base: main
Are you sure you want to change the base?
Conversation
|
I'm not entirely sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Laura plans to take more time to review this.
we need to rename FunctionScoreContainer, the java generator (and maybe others?) removes the "Container" part of the name, and since FunctionScore already exists there's a duplicate error. Does FunctionScoreCommonContainer sounds okay? Or renaming FunctionScore back to FunctionScoreQuery as is was before - feels weird being the only Query field that is not called SomethingQuery. |
Fixes #2109.