Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API generator (#4456) #4514

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix API generator (#4456) #4514

merged 1 commit into from
Mar 27, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Mar 27, 2020

This commit fixes the API generator:

  1. The collection of high level endpoints were being used in some
    of the low level generators
  2. High level endpoints excluded need to be compared to the list by filename

(cherry-picked from commit 04ed38b)

This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>

(cherry-picked from commit 04ed38b)
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit e791310 into 7.x Mar 27, 2020
@russcam russcam deleted the fix/7x-api-generator branch March 27, 2020 06:55
github-actions bot pushed a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>

(cherry-picked from commit 04ed38b)
github-actions bot pushed a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>

(cherry-picked from commit 04ed38b)
russcam added a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>

(cherry-picked from commit 04ed38b)

Co-authored-by: Russ Cam <russ.cam@elastic.co>
codebrain pushed a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>

(cherry-picked from commit 04ed38b)

Co-authored-by: Russ Cam <russ.cam@elastic.co>
(cherry picked from commit 145869b)
russcam pushed a commit that referenced this pull request Mar 30, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>
Co-authored-by: Russ Cam <russ.cam@elastic.co>

(cherry-picked from commit 04ed38b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants