Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user agent format #1954

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Update user agent format #1954

merged 2 commits into from
Jul 25, 2023

Conversation

JoshMock
Copy link
Member

I fixed the user-agent to not be elastic-transport-js in #1865, but the format was slightly inconsistent with other clients and the transport user-agent itself. Nothing drastic that will break client usage telemetry, just keeping things consistent.

Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checking out how my client did it after looking at this code, I think I found a potential issue with my client's user agent code 🙌

@JoshMock JoshMock merged commit 1049a0f into main Jul 25, 2023
26 checks passed
@JoshMock JoshMock deleted the user-agent-cleanup branch July 25, 2023 16:11
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
(cherry picked from commit 1049a0f)
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
(cherry picked from commit 1049a0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants