Fix against TimeSpan.Zero for max lifetime #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
commented
Sep 17, 2024
Mpdreamz
commented
Sep 17, 2024
| public TimeSpan OutboundBufferMaxLifetime | ||
| { | ||
| get => _outboundBufferMaxLifetime; | ||
| set => _outboundBufferMaxLifetime = value >= _outboundBufferMinLifetime ? value : _outboundBufferMaxLifetime; |
There was a problem hiding this comment.
Ensuring we can never set max life time to any thing less then 1s.
Otherwise each publish will cause an export, akin to setting OutboundBufferMaxSize to 1.
…ementation to ensure some drainage happened
| @@ -70,6 +70,6 @@ public void BulkAll() | |||
| channel.TryWriteMany(_data); | |||
| channel.TryComplete(); | |||
|
|
|||
| _waitHandle.WaitOne(); | |||
| // _waitHandle.WaitOne(); | |||
There was a problem hiding this comment.
Did you mean for this to remain uncommented?
There was a problem hiding this comment.
Reverted changes to the benchmark project, wasn't needed in this PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we never allow
TimeSpan.Zerosince it effectively will behave asOutboundBufferMaxSize = 1.This also stabilises
WaitToWriteAsyncwhen usingBoundedChannelFullMode.Waitto ensure the InboundChannel is sufficiently drained before pumping messages into inbound channel again.Fixes a similar problem as: dotnet/runtime#66281