Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cancel brush event with escape key #819

Merged
merged 6 commits into from
Sep 16, 2020
Merged

feat: cancel brush event with escape key #819

merged 6 commits into from
Sep 16, 2020

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Sep 15, 2020 •
edited
Loading

Summary

Enable canceling brushing and click of xy charts with Escape

Screen Recording 2020-09-14 at 07 06 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added enhancement New feature or request :interactions Interactions related issue :xy Bar/Line/Area chart related labels Sep 15, 2020
markov00
markov00 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks good.
nit: if we can avoid that hasBrushListener instance variable it will be great, if not I'm fine with the current implementation

@nickofthyme
Copy link
Collaborator Author

@markov00 Updated based on our talk.

@nickofthyme nickofthyme merged commit b599d13 into elastic:master Sep 16, 2020
@nickofthyme nickofthyme deleted the feat/brush-cancel branch September 16, 2020 16:55
markov00 pushed a commit that referenced this pull request Sep 16, 2020
@semantic-release-bot
chore(release): 21.3.0 [skip ci]
7aba794 
# [21.3.0](v21.2.0...v21.3.0) (2020-09-16)

### Bug Fixes

* legend dark mode hover color ([#820](#820)) ([5227b2e](5227b2e))

### Features

* cancel brush/click event with escape key ([#819](#819)) ([b599d13](b599d13))
* show crosshair for external pointer events ([#817](#817)) ([f591a6a](f591a6a))
@markov00
Copy link
Member

🎉 This PR is included in version 21.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 16, 2020
@nickofthyme nickofthyme mentioned this pull request Oct 1, 2020
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 21.3.0 [skip ci]
30def62 
# [21.3.0](elastic/elastic-charts@v21.2.0...v21.3.0) (2020-09-16)

### Bug Fixes

* legend dark mode hover color ([opensearch-project#820](elastic/elastic-charts#820)) ([d30c21f](elastic/elastic-charts@d30c21f))

### Features

* cancel brush/click event with escape key ([opensearch-project#819](elastic/elastic-charts#819)) ([5a9f21f](elastic/elastic-charts@5a9f21f))
* show crosshair for external pointer events ([opensearch-project#817](elastic/elastic-charts#817)) ([1721514](elastic/elastic-charts@1721514))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@monfera monfera Awaiting requested review from monfera

Assignees
No one assigned
Labels
enhancement New feature or request :interactions Interactions related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickofthyme @markov00