Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashed Lines Not Working #687

Closed
mtiller opened this issue May 29, 2020 · 2 comments · Fixed by #692 or elastic/kibana#69126
Closed

Dashed Lines Not Working #687

mtiller opened this issue May 29, 2020 · 2 comments · Fixed by #692 or elastic/kibana#69126
Assignees
@markov00
Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related

Comments

@mtiller
Copy link

mtiller commented May 29, 2020

When setting the line.dash value for annotation styles, it doesn't actually impact the appearance of the line.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the line styling example in the StoryBook
  2. Adjust the dash related values
  3. Note there is no change in the appearance of the line.

Expected behaviour
I would expect the appearance of the line to change. Note that I suspected a bug in the StoryBook itself, but I see the same behavior with my own annotations.

Version (please complete the following information):

  • OS: Whatever is hosting your StoryBook
  • Browser: Chrome
  • Elastic Charts: Version rendering current StoryBook (I couldn't find any indication)

Note - I don't see any examples in your StoryBook (although perhaps I missed them) that demonstrate dashed or dotted lines.
@mtiller mtiller added the bug Something isn't working label May 29, 2020
@markov00 markov00 added :annotation Annotation (line, rect, text) related issue :xy Bar/Line/Area chart related labels May 29, 2020
@markov00
Copy link
Member

markov00 commented May 29, 2020 •
edited
Loading

Thank you @mtiller I can confirm the bug, we will fix this as soon as possible.

Triage details:

  • the LineAnnotationStyle type doesn't have the StrokeDashArray prop
  • as a consequence, the renderLineAnnotations doesn't render the line with the provided dash array

@markov00 markov00 self-assigned this May 29, 2020
@markov00 markov00 mentioned this issue Jun 1, 2020
Merged
3 tasks
markov00 added a commit that referenced this issue Jun 1, 2020
@markov00
fix: missing dash style in line annotation (#692)
e2ba940 
This commit re-adds the dash style for line annotations. This probably was an existing feature before we removed Konva library, the story annotations/lines/5_styling.tsx has references to dashWidth and dashGapWidth used on the line style.
The VRT was manually updated as with the current change threshold (0,005% of the whole image) the change is not surfaced. I will open a subsequent PR to check if we can safely remove this threshold

fix #687
markov00 pushed a commit that referenced this issue Jun 1, 2020
@semantic-release-bot
chore(release): 19.4.1 [skip ci]
3009636 
## [19.4.1](v19.4.0...v19.4.1) (2020-06-01)

### Bug Fixes

* missing dash style in line annotation ([#692](#692)) ([e2ba940](e2ba940)), closes [#687](#687)
@markov00
Copy link
Member

markov00 commented Jun 1, 2020

🎉 This issue has been resolved in version 19.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 1, 2020
This was referenced Jun 10, 2020
Closed
Merged
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.4.1 [skip ci]
7d2c2e4 
## [19.4.1](elastic/elastic-charts@v19.4.0...v19.4.1) (2020-06-01)

### Bug Fixes

* missing dash style in line annotation ([opensearch-project#692](elastic/elastic-charts#692)) ([62999bc](elastic/elastic-charts@62999bc)), closes [opensearch-project#687](elastic/elastic-charts#687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
2 participants
@mtiller @markov00