Make model upload compatible with serverless clusters #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
enhancement
pquentin
approved these changes
Jun 7, 2024
Comment on lines
+200
to
+203
| if ( | ||
| "build_flavor" in es_info["version"] | ||
| and es_info["version"]["build_flavor"] == "serverless" | ||
| ): |
There was a problem hiding this comment.
It's OK to assume build_flavor is set, it was here in the 7.x days too: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/targz.html#_checking_that_elasticsearch_is_running
Suggested change
| if ( | |
| "build_flavor" in es_info["version"] | |
| and es_info["version"]["build_flavor"] == "serverless" | |
| ): | |
| if es_info["version"]["build_flavor"] == "serverless": |
There was a problem hiding this comment.
Oh it failed running against a locally built and run Elasticsearch maybe it's not in dev builds. I'd prefer to keep this to be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #696 serverless clusters always return version
8.11.0which makes the model upload script think that it does not support the upgraded version of PyTorch. The fix is to check forbuild_flavor == serverlessCloses #696