Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[686] Replace check for Elasticsearch to str/list in ensure_es_client function #690

Merged
merged 1 commit into from
May 4, 2024
Merged

[686] Replace check for Elasticsearch to str/list in ensure_es_client function #690

merged 1 commit into from
May 4, 2024

Conversation

AshokChoudhary11
Copy link
Contributor

No description provided.

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented May 3, 2024 •
edited
Loading

💚 CLA has been signed

@AshokChoudhary11
Copy link
Contributor Author

Closes #686

@pquentin
Copy link
Member

pquentin commented May 3, 2024

Hello! Thanks for your contribution. Can you please sign the CLA?

@AshokChoudhary11
Copy link
Contributor Author

Done

@pquentin
Copy link
Member

pquentin commented May 4, 2024

buildkite test this please

pquentin
pquentin approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@pquentin pquentin merged commit 5b728c2 into elastic:main May 4, 2024
6 checks passed
@pquentin pquentin mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshokChoudhary11 @pquentin