Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _append instead of append since it's still available after pandas 2.0.0 #603

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Use _append instead of append since it's still available after pandas 2.0.0 #603

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9e7306
Use _append instead of append since it's still available after 2.0 of…
bartbroere Sep 14, 2023
e34f6fc
Merge branch 'main' into use-_append
bartbroere Sep 15, 2023
d985fdf
Merge branch 'main' into use-_append
bartbroere Sep 20, 2023
a4a6b92
Merge branch 'main' into use-_append
davidkyle Sep 26, 2023
88888fa
Merge branch 'main' into use-_append
bartbroere Sep 27, 2023
8429a38
Merge branch 'main' into use-_append
davidkyle Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/etl/test_pandas_to_eland.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ def test_es_if_exists_append(self):

# Assert that the second pandas dataframe is actually appended
assert df2.shape == (6, 4)
pd_df3 = pd_df.append(pd_df2)
# use the "private" append method that's still available in pandas 2.0
pd_df3 = pd_df._append(pd_df2)
assert_pandas_eland_frame_equal(pd_df3, df2)

def test_es_if_exists_append_mapping_mismatch_schema_enforcement(self):
Expand Down