-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to entry_points #551 #559
Migrate to entry_points #551 #559
Conversation
As response to #557 (review): The following flake8 lint errors proves that noxfile covers |
I've tested this change on macOS and the script is installed into the exact same location as before, i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution @sakurai-youhei this is a great improvement for Windows users
@sakurai-youhei The build system is being migrated from Jenkins to Buildkite and there are problems which is why your PR is not passing CI. The PR did pass the CI checks previously, I've tested the change and it is good. The CI failure is nothing to do with your change so I will merge the PR and users can benefit from your change. Thanks more making the |
Closes #551.
With this PR,
eland_import_hub_model
gets easier to find on Windows.On windows:
eland_import_hub_model
is an executable file.On Linux:
eland_import_hub_model
is a simple auto-generated script file.Note: Because I come to think adding
python -m eland
would be too ambicious, I dropped it from the scope.