Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] adds new auto task type that attempts to automatically determine NLP task type from model config #475

Conversation

benwtrent
Copy link
Member

For many model types, we don't need to require the task requested. We can infer the task type based on the model configuration and architecture.

This commit makes the task-type parameter optional for the model up load script and adds logic for auto-detecting the task type based on the 🤗 model.

@benwtrent benwtrent added enhancement New feature or request topic:NLP Issue or PR about NLP model support and eland_import_hub_model labels Jun 22, 2022
@benwtrent benwtrent requested a review from davidkyle June 22, 2022 20:32
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

bin/eland_import_hub_model Outdated Show resolved Hide resolved
Co-authored-by: David Kyle <david.kyle@elastic.co>
@benwtrent benwtrent merged commit 8892f4f into elastic:main Jun 23, 2022
@benwtrent benwtrent deleted the feature/ml-add-auto-task-type-for-huggingface-upload branch June 23, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants