-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es_type_overrides should error when receiving non-existing entries #302
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Jenkins test this please |
Builds are good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments then looks good!
CI workflows are failing because, we are using elasticsearch You want me to add it? |
Instead of installing |
Hmm. Now pandoc is not installed 🤯 |
ah, likely need a |
@V1NAY8 I pushed to your branch, recommend you do a pull. |
Yes, pulled it, Now the CI are successful . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, thank you for this! 🎉 🥳
Closes #280
@sethmlarson Please review 😄