Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es_type_overrides should error when receiving non-existing entries #302

Merged
merged 5 commits into from
Oct 27, 2020

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Oct 27, 2020

Closes #280

@sethmlarson Please review 😄

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sethmlarson
Copy link
Contributor

Jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Oct 27, 2020

Builds are good :)

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments then looks good!

eland/field_mappings.py Outdated Show resolved Hide resolved
eland/field_mappings.py Outdated Show resolved Hide resolved
eland/field_mappings.py Outdated Show resolved Hide resolved
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Oct 27, 2020

CI workflows are failing because, we are using elasticsearch
Hence we need to add python3.8 -m pip install nox elasticsearch in yml

You want me to add it?

@sethmlarson
Copy link
Contributor

Instead of installing elasticsearch can you move the import elasticsearch from the global scope to inside the try-except for es_active?

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Oct 27, 2020

Hmm. Now pandoc is not installed 🤯

@sethmlarson
Copy link
Contributor

ah, likely need a apt-get install pandoc within the github action?

@sethmlarson
Copy link
Contributor

@V1NAY8 I pushed to your branch, recommend you do a pull.

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Oct 27, 2020

Yes, pulled it, Now the CI are successful .

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thank you for this! 🎉 🥳

@sethmlarson sethmlarson merged commit e17b4e0 into elastic:master Oct 27, 2020
@V1NAY8 V1NAY8 deleted the issue/280 branch October 27, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

es_type_overrides should error when receiving non-existing entries
3 participants